Re: [PATCH v5 02/14] trailer: process trailers from file and arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2014, 18:14 UTC
Message-ID: <xmqq61omu96d.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140209.145205.1882309246743951569.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 15 quoted lines

> This is what "if_exists" and "if_missing" are all about.
>
> Either:
>
> 	the same key already exists regardless of the value
>
> and, in this case, what happens depends on what has been specified using
> the "if_exists" configuration variable.
>
> Or:
>
> 	the same key DOES NOT already exists regardless of the value
>
> and in this case, what happens depends on what has been specified
> using the "if_missing" configuration variable.

Hmm, how should things like signed-off-by be handled? You may want to allow many entries with the same key with distinct values, but duplicated values may want to be handled differently (currently we only avoid to place a duplicate <key, value> consecutively, but keys with different semantics (e.g. "fixes-bug: #bugid") may want to say "unless the same key with the same value exists, append it at the end".