Re: [PATCH v5 01/14] Add data structures and basic functions for commit trailers

> From: Junio C Hamano <gitster@pobox.com>
>>
>> Christian Couder <chriscool@tuxfamily.org> writes:
>>
>>> +static inline int same_trailer(struct trailer_item *a, struct trailer_item *b, int alnum_len)
>>> +{
>>> +    return same_token(a, b, alnum_len) && same_value(a, b);
>>> +}
>>
>> All these "inlines" look premature optimization that can be
>> delegated to any decent compiler, don't they?
>
> Yeah, but as Eric suggested to add them like in header files and you
> did not reply to him, I thought you agreed with him.
> I will remove them.

>>> +/* Get the length of buf from its beginning until its last alphanumeric character */
>>> +static inline size_t alnum_len(const char *buf, int len)
>>> +{
>>> +    while (--len >= 0 && !isalnum(buf[len]));
>>> +    return (size_t) len + 1;
>>
>> This is somewhat unfortunate.  if the caller wants to receive
>> size_t, perhaps it should be passing in size_t (or ssize_t) to the
>> function?  Hard to guess without an actual caller, though.
>
> Ok, I will make it return an int.