Re: [PATCH v5 07/14] trailer: add interpret-trailers command

From: Christian Couder <christian.couder@gmail.com>
Date: Feb 7, 2014, 08:34 UTC
Message-ID: <CAP8UFD10aGq+cUcaiMHRKsLLKvF1eYUuM+G85MRHqhwBXZVv-g@mail.gmail.com>
In-Reply-To: <xmqqiosrwzoh.fsf@gitster.dls.corp.google.com>

On Fri, Feb 7, 2014 at 1:10 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> diff --git a/git.c b/git.c
>> index 3799514..1420b58 100644
>> --- a/git.c
>> +++ b/git.c
>> @@ -383,6 +383,7 @@ static void handle_internal_command(int argc, const char **argv)
>>               { "index-pack", cmd_index_pack, RUN_SETUP_GENTLY },
>>               { "init", cmd_init_db },
>>               { "init-db", cmd_init_db },
>> +             { "interpret-trailers", cmd_interpret_trailers, RUN_SETUP },
>>               { "log", cmd_log, RUN_SETUP },
>>               { "ls-files", cmd_ls_files, RUN_SETUP },
>>               { "ls-remote", cmd_ls_remote, RUN_SETUP_GENTLY },
>
> Does this even need to have a git repository?  What is the RUN_SETUP
> for?

It needs to read git config files, but it could work without reading them too. I will have another look at it.

Thanks, Christian.