Re: [PATCH v5 10/14] trailer: execute command from 'trailer.<name>.command'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 7, 2014, 00:18 UTC
- Message-ID
- <xmqq4n4bwzb1.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140206202004.325.54178.chriscool@tuxfamily.org>
Christian Couder <chriscool@tuxfamily.org> writes:
> +#define TRAILER_ARG_STRING "$ARG"
No need to support users who may want to use a string that happens to match this substring literally as part of the command line?
Show 8 quoted lines
> struct trailer_item {
> struct trailer_item *previous;
> struct trailer_item *next;
> @@ -56,6 +60,13 @@ static inline int contains_only_spaces(const char *str)
> return !*s;
> }
>
> +static inline void strbuf_replace(struct strbuf *sb, const char *a, const char *b)Same comment about "inline" for an earlier patch applies.