Re: [PATCH v2 06/18] maintenance: add --task option

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2020, 22:18 UTC
Message-ID: <xmqq5zadq3ir.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqimeeq8x4.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

>>  	for (i = 0; !result && i < num_tasks; i++) {
>> -		if (!tasks[i]->enabled)
>> +		if (opts.tasks_selected && !tasks[i]->selected)
>> +			continue;
>> +
>> +		if (!opts.tasks_selected && !tasks[i]->enabled)
>>  			continue;
>
> I am not sure about this.  Even if the task <x> is disabled, if the
> user says --task=<x>, it is run anyway?  Doesn't make an immediate
> sense to me.

OK, after seeing the title of 12/18, it does make sense. Even if it is disabled by default, you could still choose to run, which makes sense.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.