Re: [PATCH v2 06/18] maintenance: add --task option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2020, 19:50 UTC
- Message-ID
- <xmqqtuxwlmkb.fsf@gitster.c.googlers.com>
- In-Reply-To
- <2c5e5ed3-155e-f963-02c8-2789c799f3f7@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 17 quoted lines
>>> for (i = 0; !result && i < num_tasks; i++) {
>>> - if (!tasks[i]->enabled)
>>> + if (opts.tasks_selected && !tasks[i]->selected)
>>> + continue;
>>> +
>>> + if (!opts.tasks_selected && !tasks[i]->enabled)
>>> continue;
>>
>> I am not sure about this. Even if the task <x> is disabled, if the
>> user says --task=<x>, it is run anyway? Doesn't make an immediate
>> sense to me.
>> ...
>> if (!tasks[i]->enabled ||
>> !(!opts.tasks_selected || tasks[i]->selected))
>> continue;
>
> This isn't quite right, due to the confusing nature of "enabled".Yes, in the message you are responding to, I was still assuming that --task=foo that defeat task.foo.enabled=no would be a bug. If we want to run disabled tasks by selection, of course the condition would need to change.