Re: [PATCH v3 00/20] Maintenance builtin, allowing 'gc --auto' customization
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2020, 02:58 UTC
- Message-ID
- <xmqqlfj04ch6.fsf@gitster.c.googlers.com>
- In-Reply-To
- <xmqqzh7g60mk.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 14 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> * This series is now based on jk/strvec, as there are several places where >> I was adding new callers to argv_array_push* and run_command_v_opt() >> which have been replaced with strvec_push*() and run_command(), using a >> 'struct child_process'. > > It probably has been a good way to gain experience with the renamed > API for you to rebase this series, but I think we'd have to spend a > similar amount of effort yet again, as I expect that the jk/strvec > series would be rerolled at least once more, with the items[] array > renamed to something else, like v[]. > > Let's see how it goes.
So, ... jk/strvec got updated, and just applying these twenty patches on top no longer compiles, so I rebased them ;-)
I also adjusted the merge-fix for the 6 patches on es/config-hooks topic before making tonight's final push-out of 'seen'.
Thanks.