Re: [PATCH 00/21] Maintenance builtin, allowing 'gc --auto' customization

From: Derrick Stolee <stolee@gmail.com>
Date: Jul 9, 2020, 15:54 UTC
Message-ID: <52715fe8-a545-5c42-2f3a-e59bcbc43497@gmail.com>
In-Reply-To: <xmqqv9iwyeac.fsf@gitster.c.googlers.com>

On 7/9/2020 10:05 AM, Junio C Hamano wrote:

Show 6 quoted lines

> For existing callers, "git gc --auto" may want to be left alive,
> merely as a thin wrapper around "git maintenance --auto", and as
> long as the latter is done in the same spirit of the former, i.e.
> perform a lightweight check to see if the repository is so out of
> shape and then do a minimum cleaning, it would be welcomed by users
> if it does a lot more than the current "git gc --auto".

It's entirely possible that (after the 'maintenance' builtin stabilizes) that we make 'git gc --auto' become an alias of something like 'git maintenance run --task=gc --auto' (or itemize all of the sub-tasks) so that 'git gc --auto' doesn't change behavior.

That's a big motivation for adding all code into builtin/gc.c so we can access these tasks inside GC without needing to move or copy the code. I'm trying to preserve history as much as possible.

Thanks, -Stolee