From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 23 Jul 2020 22:18:20 GMT
Subject: Re: [PATCH v2 06/18] maintenance: add --task option
Message-ID: <xmqq5zadq3ir.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqimeeq8x4.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

>>  	for (i = 0; !result && i < num_tasks; i++) {
>> -		if (!tasks[i]->enabled)
>> +		if (opts.tasks_selected && !tasks[i]->selected)
>> +			continue;
>> +
>> +		if (!opts.tasks_selected && !tasks[i]->enabled)
>>  			continue;
>
> I am not sure about this.  Even if the task <x> is disabled, if the
> user says --task=<x>, it is run anyway?  Doesn't make an immediate
> sense to me.

OK, after seeing the title of 12/18, it does make sense.  Even if it
is disabled by default, you could still choose to run, which makes
sense.