git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] last-modified: rewrite error message when more than one revision given

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2026, 17:16 UTC
Message-ID
<xmqq3445a370.fsf@gitster.g>
In-Reply-To
<aWnkJ_GpgbXBPwFp@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
>> Surprised that “revision” is a synonym for commit? Why is that?
>
> Because in my mind a revision can resolve to any object type.

Yup, in the early days of this mailing list (like in 2005 ;-), the word "revision" was used more or less interchangeably with "object name", but "a revision" was much more likely to refer to a commit than "an object name". The name of the file that implements one of the more core-ish part of the system is "revision.c" and talks about "revision traversal", which is mostly about following parent pointers in commit DAG, but also follows into trees starting from commits.

> Also, it's confusing to conflate the way to name a commit with a commit
> itself. "HEAD~10" is a revision, but taken by itself it's not a commit.

I do not know about this. If HEAD~10 does not resolve to anything, it would not be a commit and it would not be a revision, either.

> It's not even clear whether it resolves, so it feels sensible to me to
> keep these two concepts separate from one another.
>
> Patrick
Previous: Toon ClaesNext: Patrick Steinhardt
Message 12 of 55 in “last-modified: verify revision argument is a commit-ish”
  1. last-modified: verify revision argument is a commit-ishToon Claes, Jan 12, 2026
  2. Junio C HamanoJan 12, 2026
  3. Patrick SteinhardtJan 13, 2026
  4. 0/3 Fix git-last-modified(1) bug triggered when passing a tree-ishToon Claes, Jan 14, 2026
  5. 1/3 last-modified: rewrite error message when more than one revision givenToon Claes, Jan 14, 2026
  6. Patrick SteinhardtJan 14, 2026
  7. Toon ClaesJan 15, 2026
  8. Patrick SteinhardtJan 15, 2026
  9. Kristoffer HaugsbakkJan 15, 2026
  10. Patrick SteinhardtJan 16, 2026
  11. Toon ClaesJan 16, 2026
  12. Junio C HamanoJan 16, 2026
  13. Patrick SteinhardtJan 19, 2026
  14. Kristoffer HaugsbakkJan 25, 2026
  15. Kristoffer HaugsbakkJan 15, 2026
  16. 2/3 last-modified: remove double error messageToon Claes, Jan 14, 2026
  17. Patrick SteinhardtJan 14, 2026
  18. 3/3 last-modified: verify revision argument is a commit-ishToon Claes, Jan 14, 2026
  19. Patrick SteinhardtJan 14, 2026
  20. Kristoffer HaugsbakkJan 15, 2026
  21. Junio C HamanoJan 15, 2026
  22. Toon ClaesJan 16, 2026
  23. 0/4 Fix git-last-modified(1) bug triggered when passing a tree-ishToon Claes, Jan 16, 2026
  24. 1/4 last-modified: rewrite error message when more than one revision givenToon Claes, Jan 16, 2026
  25. Junio C HamanoJan 16, 2026
  26. 2/4 last-modified: fix memory leak when more than one revision is givenToon Claes, Jan 16, 2026
  27. 3/4 last-modified: remove double error messageToon Claes, Jan 16, 2026
  28. Junio C HamanoJan 16, 2026
  29. 4/4 last-modified: verify revision argument is a commit-ishToon Claes, Jan 16, 2026
  30. Junio C HamanoJan 16, 2026
  31. 0/4 Fix git-last-modified(1) bug triggered when passing a tree-ishToon Claes, Jan 23, 2026
  32. 1/4 last-modified: rewrite error message when more than one revision givenToon Claes, Jan 23, 2026
  33. Junio C HamanoJan 23, 2026
  34. 2/4 last-modified: fix memory leak when more than one revision is givenToon Claes, Jan 23, 2026
  35. Junio C HamanoJan 23, 2026
  36. 3/4 last-modified: remove double error messageToon Claes, Jan 23, 2026
  37. Junio C HamanoJan 23, 2026
  38. 4/4 last-modified: verify revision argument is a commit-ishToon Claes, Jan 23, 2026
  39. Junio C HamanoJan 23, 2026
  40. Junio C HamanoJan 23, 2026
  41. 0/4 Fix git-last-modified(1) bug triggered when passing a tree-ishToon Claes, Jan 27, 2026
  42. 1/4 last-modified: rewrite error message when more than one commit givenToon Claes, Jan 27, 2026
  43. 2/4 last-modified: fix memory leak when more than one commit is givenToon Claes, Jan 27, 2026
  44. 3/4 last-modified: remove double error messageToon Claes, Jan 27, 2026
  45. 4/4 last-modified: verify revision argument is a commit-ishToon Claes, Jan 27, 2026
  46. Junio C HamanoJan 27, 2026
  47. Toon ClaesJan 29, 2026
  48. 0/4 Fix git-last-modified(1) bug triggered when passing a tree-ishToon Claes, Jan 30, 2026
  49. 1/4 last-modified: rewrite error message when more than one commit givenToon Claes, Jan 30, 2026
  50. 2/4 last-modified: fix memory leak when more than one commit is givenToon Claes, Jan 30, 2026
  51. 3/4 last-modified: remove double error messageToon Claes, Jan 30, 2026
  52. 4/4 last-modified: verify revision argument is a commit-ishToon Claes, Jan 30, 2026
  53. Patrick SteinhardtFeb 6, 2026
  54. Junio C HamanoJan 30, 2026
  55. Patrick SteinhardtFeb 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.