[PATCH v2 2/3] last-modified: remove double error message
- From
Toon Claes <toon@iotcl.com>
- Date
- Jan 14, 2026, 10:24 UTC
- Message-ID
- <20260114-toon-last-modified-tree-v2-2-ba3b1860898f@iotcl.com>
- In-Reply-To
- <20260114-toon-last-modified-tree-v2-0-ba3b1860898f@iotcl.com>
When the user passes two revisions, they get the following output:
$ git last-modified HEAD HEAD~
error: last-modified can only operate on one revision at a time
error: unable to setup last-modifiedThe error message about "unable to setup" is not very informative, remove it.
Signed-off-by: Toon Claes <toon@iotcl.com> --- builtin/last-modified.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/last-modified.c b/builtin/last-modified.c index 06e3f79aec..0df85be318 100644 --- a/builtin/last-modified.c +++ b/builtin/last-modified.c @@ -495,7 +495,7 @@ static int last_modified_init(struct last_modified *lm, struct repository *r, lm->rev.bloom_filter_settings = get_bloom_filter_settings(lm->rev.repo); if (populate_paths_from_revs(lm) < 0) - return error(_("unable to setup last-modified")); + return -1; CALLOC_ARRAY(lm->all_paths, hashmap_get_size(&lm->paths)); lm->all_paths_nr = 0;
-- 2.52.0