[PATCH v3 1/4] last-modified: rewrite error message when more than one revision given
- From
Toon Claes <toon@iotcl.com>
- Date
- Jan 16, 2026, 13:08 UTC
- Message-ID
- <20260116-toon-last-modified-tree-v3-1-e6ade4dc35ab@iotcl.com>
- In-Reply-To
- <20260116-toon-last-modified-tree-v3-0-e6ade4dc35ab@iotcl.com>
When more than one revision is passed to the git-last-modified(1) command, this error message was printed:
error: last-modified can only operate on one tree at a time
Calling these a "tree" is technically not correct. git-last-modified(1) expects revisions that peel to a commit.
Rephrase the error message to:
error: last-modified can only operate on one revision at a time
Signed-off-by: Toon Claes <toon@iotcl.com> --- builtin/last-modified.c | 2 +- t/t8020-last-modified.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/last-modified.c b/builtin/last-modified.c index c80f0535f6..7d95244e3f 100644 --- a/builtin/last-modified.c +++ b/builtin/last-modified.c @@ -146,7 +146,7 @@ static int populate_paths_from_revs(struct last_modified *lm) continue; if (num_interesting++) - return error(_("last-modified can only operate on one tree at a time")); + return error(_("last-modified can only operate on one revision at a time")); diff_tree_oid(lm->rev.repo->hash_algo->empty_tree, &obj->item->oid, "", &diffopt); diff --git a/t/t8020-last-modified.sh b/t/t8020-last-modified.sh index 50f4312f71..1183ae667b 100755 --- a/t/t8020-last-modified.sh +++ b/t/t8020-last-modified.sh @@ -12,7 +12,7 @@ test_expect_success 'setup' ' test_commit 3 a/b/file ' -test_expect_success 'cannot run last-modified on two trees' ' +test_expect_success 'cannot run last-modified on two revision' ' test_must_fail git last-modified HEAD HEAD~1 '
-- 2.52.0