Re: [PATCH v2 1/3] last-modified: rewrite error message when more than one revision given

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jan 15, 2026, 14:34 UTC
Message-ID: <116c267a-35c7-4159-8f7a-62792de4644b@app.fastmail.com>
In-Reply-To: <87jyxjjejz.fsf@iotcl.com>

On Thu, Jan 15, 2026, at 12:33, Toon Claes wrote:

Show 16 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>> On Wed, Jan 14, 2026 at 11:24:45AM +0100, Toon Claes wrote:
>>>[snip]
>>> -		if (num_interesting++)
>>> -			return error(_("last-modified can only operate on one tree at a time"));
>>> +		if (num_interesting++) {
>>> +			ret = error(_("last-modified can only operate on one revision at a time"));
>>
>> Do we maybe want to be a bit more specific and say committish instead of
>> revision?
>
> I was thinking about mentioning something like "commit-ish" instead, but
> I felt "commit-ish" isn't a commonly used term toward end-users. Looking
> at gitglossary(7), it says "revision" is a "synonym for commit". I'm
> happy to change this message, but I'm not sure s/revision/commit-ish/ is
> the best change for this.

I just stumbled upon the “IDENTIFIER TERMINOLOGY” section of git(1). “commit-ish” is there.

>[snip]