Re: [PATCH v6 4/4] last-modified: verify revision argument is a commit-ish

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 6, 2026, 15:55 UTC
Message-ID: <aYYO8Ph5yTE1ip-q@pks.im>
In-Reply-To: <20260130-toon-last-modified-tree-v6-4-db827e5df985@iotcl.com>

On Fri, Jan 30, 2026 at 03:26:38PM +0100, Toon Claes wrote:

Show 13 quoted lines

> diff --git a/t/t8020-last-modified.sh b/t/t8020-last-modified.sh
> index d1aad12319..ec5bdc6aa0 100755
> --- a/t/t8020-last-modified.sh
> +++ b/t/t8020-last-modified.sh
> @@ -30,7 +31,7 @@ check_last_modified() {
>  
>  	cat >expect &&
>  	git ${indir:+-C "$indir"} last-modified "$@" >tmp.1 &&
> -	git name-rev --annotate-stdin --name-only --tags \
> +	git name-rev --annotate-stdin --name-only --tags --exclude=t2 \
>  		<tmp.1 >tmp.2 &&
>  	tr '\t' ' ' <tmp.2 >actual &&
>  	test_cmp expect actual

It's quite curious that we need to explicitly exclude t2 here to get a deterministic result. But both of the results are correct, and in fact I've seen it once before that we got different results on different platforms.

Sooo... weird, but I'd say we can live with this weirdness. Doubly so because it's not the fault of this patch series.

Patrick