Re: [PATCH v2 3/3] last-modified: verify revision argument is a commit-ish

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jan 15, 2026, 16:02 UTC
Message-ID: <bc0db8d5-3c5f-4dd4-9c35-ccb02a6bf5c9@app.fastmail.com>
In-Reply-To: <20260114-toon-last-modified-tree-v2-3-ba3b1860898f@iotcl.com>

On Wed, Jan 14, 2026, at 11:24, Toon Claes wrote:

Show 7 quoted lines

> Passing a tree OID to git-last-modified(1) would trigger BUG behavior.
>
>     git last-modified HEAD^{tree}
>     BUG: builtin/last-modified.c:456: paths remaining beyond boundary
> in last-modified
>
> Fix this error by verifying the parsed revision peels to a commit-ish.

Nitpick: “peels to commit-ish” = commit-ish so this is a bit
redundant. Either just “commit-ish” or “peels to commit” would be
enough.

s/verifying the parsed revision peels to a commit-ish./verifying that the parsed revision is a commit-ish./

>
> While at it, also fix a memory leak in populate_paths_from_revs().

(Whether or not this is a stale sentence (see Patricks’)) Why not a separate commit for fixing a memory leak?

Show 5 quoted lines

>
> Reported-by: Gusted <gusted@codeberg.org>
> Signed-off-by: Toon Claes <toon@iotcl.com>
> ---
>[snip]