Re: [PATCH 4/5] rebase -i: learn to abbreviate command names

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 27, 2017, 05:19 UTC
Message-ID: <xmqq1skke1so.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171127045514.25647-5-liambeguin@gmail.com>

Liam Beguin <liambeguin@gmail.com> writes:

>  	if (command == MAKE_SCRIPT && argc > 1)
> -		return !!sequencer_make_script(keep_empty, stdout, argc, argv);
> +		return !!sequencer_make_script(keep_empty, abbreviate_commands,
> +					       stdout, argc, argv);

This suggests that a preliminary clean-up to update the parameter list of sequencer_make_script() is in order just before this step. How about making it like so, perhaps:

    int sequencer_make_script(FILE *out, int ac, char **av, unsigned flags)

where keep_empty becomes just one bit in that flags word. Then another bit in the same flags word can be used for this option.

Otherwise, every time somebody comes up with a new and shiny feature for the function, we'd end up adding more to its parameter list.