Re: [PATCH v2 6/9] rebase -i: update functions to use a flags parameter

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 4, 2017, 15:46 UTC
Message-ID: <alpine.DEB.2.21.1.1712041643250.98586@virtualbox>
In-Reply-To: <20171203221721.16462-7-liambeguin@gmail.com>

Hi Liam,

On Sun, 3 Dec 2017, Liam Beguin wrote:

Show 12 quoted lines

> diff --git a/sequencer.h b/sequencer.h
> index 4e444e3bf1c4..3bb6b0658192 100644
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -45,10 +45,12 @@ int sequencer_continue(struct replay_opts *opts);
>  int sequencer_rollback(struct replay_opts *opts);
>  int sequencer_remove_state(struct replay_opts *opts);
>  
> -int sequencer_make_script(int keep_empty, FILE *out,
> -		int argc, const char **argv);
> +#define TODO_LIST_KEEP_EMPTY (1U << 0)
> +#define TODO_LIST_SHORTED_IDS (1U << 1)

Maybe SHORTEN_IDs? And either revert back to transform_todo_ids() or use SHORTEN_INSNS...

Maybe also TRANSFORM_TODO_LIST_* and maybe move the #define's above the transform_todo_ids() function, i.e. one line further down?

Show 8 quoted lines

> +int sequencer_make_script(FILE *out, int argc, const char **argv,
> +			  unsigned flags);
>  
> -int transform_todo_insn(int shorten_ids);
> +int transform_todo_insn(unsigned flags);
>  int check_todo_list(void);
>  int skip_unnecessary_picks(void);
>  int rearrange_squash(void);

Ciao, Johannes