Re: [PATCH v2 8/9] rebase -i: learn to abbreviate command names

From: Liam Beguin <liambeguin@gmail.com>
Date: Dec 25, 2017, 15:39 UTC
Message-ID: <CAKm4OoWgB7tz0HJorDzL9Xy+fX0LVE1eOVngrfMTMDQQUTDk4Q@mail.gmail.com>
In-Reply-To: <CACsJy8B3U0_sJeEt+gLy9HJKszO5-uRZsssL3ZFdkKbSM9yWDg@mail.gmail.com>

Hi Duy,

On Mon, 25 Dec 2017 at 07:48 Duy Nguyen <pclouds@gmail.com> wrote:

Show 16 quoted lines

>
> On Mon, Dec 4, 2017 at 5:17 AM, Liam Beguin <liambeguin@gmail.com> wrote:
> > +static const char command_to_char(const enum todo_command command)
> > +{
> > +       if (command < TODO_COMMENT && todo_command_info[command].c)
> > +               return todo_command_info[command].c;
> > +       return comment_line_char;
> > +}
>
>     CC sequencer.o
> sequencer.c:798:19: error: type qualifiers ignored on function return
> type [-Werror=ignored-qualifiers]
>  static const char command_to_char(const enum todo_command command)
>                    ^
>
> Maybe drop the first const.

Sorry, that's another copy-edit error I made that slipped through... I'm curious, how did you build to get this error to show? I tried with the DEVELOPER 'flag' but nothing showed and -Wextra gave way too much messages... Did you just add -Wignored-qualifiers to CFLAGS?

> --
> Duy

Thanks, Liam