Re: [PATCH v2 02/17] chunk-format: create chunk format write API

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2021, 22:40 UTC
Message-ID: <xmqq1rdv5uej.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqq5z375xxf.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

>> +void add_chunk(struct chunkfile *cf,
>> +	       uint64_t id,
>> +	       chunk_write_fn fn,
>> +	       size_t size);
>
> Shouldn't this match the order of members in chunk_info struct?

Nah. Unless there are other reasons to touch numerous add_chunk() calls that have already been written (like we find a need to add a new parameter to the call), I do not think this matters too much.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.