Re: [PATCH v2 16/17] chunk-format: restore duplicate chunk checks

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 5, 2021, 12:31 UTC
Message-ID: <0b851243-e4c0-856e-05c3-eb670739cf6b@gmail.com>
In-Reply-To: <xmqq4kir4bw7.fsf@gitster.c.googlers.com>

On 2/4/2021 7:05 PM, Junio C Hamano wrote:

Show 14 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>  	const void *start;
>> +	unsigned found:1;
> 
> This defines a .found member ...
>> ... and no new code touches it.
> 
> The way duplicate is found is by having a inner loop that checks the
> IDs of chunks we've seen so far (quadratic, but presumably that
> would not matter as long as we'd be dealing with just half a dozen
> chunk types).
> 
> Is the .found bit used for something else and needs to be added in a
> different step?

Nope. It is just noise that I should have caught and deleted.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.