Re: [PATCH v2 09/17] midx: return success/failure in chunk write methods

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 5, 2021, 11:42 UTC
Message-ID: <b00734a3-0a45-463b-55b2-ef8cbb19d76b@gmail.com>
In-Reply-To: <xmqqlfc34eyd.fsf@gitster.c.googlers.com>

On 2/4/2021 5:59 PM, Junio C Hamano wrote:

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> In this step I see the same "f->total + f->offset" sprinkled in some
> places, but they will all go away in the "midx: use chunk-format API
> in write_midx_internal()" step, so it is not such a huge deal.

I'll move the ones that are introduced by this patch, but others already exist that also get removed by a later patch. I won't touch those until they are deleted.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.