Re: [PATCH v2 00/17] Refactor chunk-format into an API

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2021, 02:08 UTC
Message-ID: <xmqqa6sj2rm1.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.848.v2.git.1611759716.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> This is a restart on the topic previously submitted [1] but dropped because
> ak/corrected-commit-date was still in progress. This version is based on
> that branch.

I've read the topic through, and found it a pleasant read. There are some questionable use of integer types, some uneven application of casts, and the reading side API is somewhat underdocumented, but the overall direction looked quite sane.

I am undecided if I should expect a reroll, or declare what we have "already good enough" for 'next' and expect incremental refinements, though. A reroll that catches all nits would certainly make the resulting topic's history nicer for future developers to work with, but its also a pain to re-read essentially the same patches again, so...