Re: [PATCH v4 03/17] commit-graph: use chunk-format write API

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2021, 19:44 UTC
Message-ID: <xmqqv9ahz1x2.fsf@gitster.g>
In-Reply-To: <bb2ca73b-f60b-0030-2b28-753da48bf7a5@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 14 quoted lines

>>> This patch series messes up the "Writing out commit graph" progress
>>> display, and starting at this commit I get:
>
> Thanks for the report and identifying the exact place that caused the
> mistake.
>  
>> I can confirm. It looks like we never dropped the 'num_chunks' variable,
>> which should have happened in this patch.
>
> Yes, makes sense. Hard to see that 'num_chunks' wasn't used because it
> _was_ being used, just not as intended.
> ...
>
> This is obviously correct. Thanks for the quick patch!

Thanks all for noticing and fixing before the series hit the master branch.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.