From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Feb 2021 22:40:20 GMT
Subject: Re: [PATCH v2 02/17] chunk-format: create chunk format write API
Message-ID: <xmqq1rdv5uej.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqq5z375xxf.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

>> +void add_chunk(struct chunkfile *cf,
>> +	       uint64_t id,
>> +	       chunk_write_fn fn,
>> +	       size_t size);
>
> Shouldn't this match the order of members in chunk_info struct?

Nah.  Unless there are other reasons to touch numerous add_chunk()
calls that have already been written (like we find a need to add a
new parameter to the call), I do not think this matters too much.

Thanks.