Re: [WIP/PATCH v4 1/8] for-each-ref: extract helper functions out of grab_single_ref()
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 31, 2015, 20:39 UTC
- Message-ID
- <vpqvbf8jxbr.fsf@anie.imag.fr>
- In-Reply-To
- <xmqqvbf8abwi.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> /*
>> + * Given a refname, return 1 if the refname matches with one of the patterns
>> + * while the pattern is a pathname like 'refs/tags' or 'refs/heads/master'
>> + * and so on, else return 0. Supports use of wild characters.
>> + */
>> +static int match_name_as_path(const char **pattern, const char *refname)
>> +{
>
> I wonder why this is not "match_refname", in other words, what the
> significance of "as path" part of the name?Just match_refname may not carry all the semantics of the function, which matches a prefix up to the end of string, or up to a / (but you can't just be a prefix stopping in the middle of a word). To me, the "_as_path" helped understanding the overall behavior of the function.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/