Re: [WIP/PATCH v4 5/8] for-each-ref: introduce 'ref_filter_clear_data()'
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- May 31, 2015, 08:20 UTC
- Message-ID
- <556AC44B.8070709@gmail.com>
- In-Reply-To
- <CAP8UFD341nSMLvsXynbDfQ4kLoddBL5rhXrhyePTT0LHACzfuQ@mail.gmail.com>
Show 8 quoted lines
>
> As this is clearing the array only, it would be better to have it in a
> ref_array_clear() function.
> There are already argv_array_clear() and sha1_array_clear() by the way.
> And maybe if many such ref_array functions are created and start being
> used elsewhere we can easily move everything into new ref-array.{c,h}
> files.
>Makes sense. Will change.
-- Regards, Karthik