Re: [PATCH 0/3] Add a "fix" command to "rebase --interactive"

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Dec 4, 2009, 17:40 UTC
Message-ID: <vpqfx7qocwl.fsf@bauges.imag.fr>
In-Reply-To: <4B192701.4000308@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 8 quoted lines

>> If the idea of a "fix" command is acceptable, then I would like to
>> implement a further convenience: if a group of commits to be folded
>> together includes *only* "fix" commits, then the first log message
>> should be used without even opening an editor.  But I would like to
>> get a reaction to the "fix" command in general before doing so.
>
> I'd say that would make a useful command ("fix") even more useful, being
> just the right counterpart to "reword" for trivial commit message fixes.

+1 for fix, and +1 for the "don't even launch the editor" too.

> OTOH, it would not be possible any more to squash in a few fixes and
> then edit the message. Maybe having to quit the editor is not that much
> work after all.

Well, it's still possible, by using "squash" and deleting the extra part. In both cases, there's one scenario where one has a little more to do than strictly required (either delete a bit of texte or close the editor), but I think the senario "just want to fix the content with another patch, but the commit message was good" is so common that it deserves being optimized.

In particular, that would make a rebase -i with only reordering and fixes non-interactive. With 3 fixes, you just wait for Git around a second and it's done, smoothly, while it requires launching/closing the editor 3 times ...

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/