Re: [PATCH 0/3] Add a "fix" command to "rebase --interactive"
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 4, 2009, 18:47 UTC
- Message-ID
- <alpine.DEB.1.00.0912041945161.21557@intel-tinevez-2-302>
- In-Reply-To
- <7vws12r5v2.fsf@alter.siamese.dyndns.org>
Hi,
On Fri, 4 Dec 2009, Junio C Hamano wrote:
Show 19 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
> > Michael J Gruber <git@drmicha.warpmail.net> writes:
> >
> >>> If the idea of a "fix" command is acceptable, then I would like to
> >>> implement a further convenience: if a group of commits to be folded
> >>> together includes *only* "fix" commits, then the first log message
> >>> should be used without even opening an editor. But I would like to
> >>> get a reaction to the "fix" command in general before doing so.
> >>
> >> I'd say that would make a useful command ("fix") even more useful, being
> >> just the right counterpart to "reword" for trivial commit message fixes.
> >
> > +1 for fix, and +1 for the "don't even launch the editor" too.
>
> I like it, too. Also I vaguely recall that there was a series that died
> that would have allowed you to give hints to help this behaviour at the
> time you make "fix-up" commits; we may want to resurrect it on top of this
> feature.I'll just repeat this exactly one more time: it is not always possible to know whether you make a fix-up commit, and it is not always possible to be sure that you want to amend the next time you do a rebase.
So: Commit time is definitely a bad time to decide on the action in some future rebase event.
Ciao, Dscho