Re: [PATCH 0/3] Add a "fix" command to "rebase --interactive"

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Dec 8, 2009, 14:39 UTC
Message-ID: <vpqfx7l1qdi.fsf@bauges.imag.fr>
In-Reply-To: <20091208121314.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

> Teach a new option, --autosquash, to the interactive rebase.
> When the commit log message begins with "!fixup ...", and there
> is a commit whose title begins with the same ...

You should be clearer than "title" here. My understanding is that this is the _message_ (man git-commit talks about log message or commit message).

It's a detail, but I could make sense to allow putting something other than the commit message here, like an object name:

git commit -m "fixup! 66eb61bd" git commit -m "fixup! HEAD^^"

The last one is a bit tricky, since it should mean "HEAD^^" right before I did the commit.

All that said, I probably won't be a user of that particular feature (although I love the new "fixup" command for rebase -i), so don't see any complaint here, just food for thoughts ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/