Re: [PATCH 0/3] Add a "fix" command to "rebase --interactive"

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2009, 22:29 UTC
Message-ID: <7v4oo6l6ef.fsf@alter.siamese.dyndns.org>
In-Reply-To: <6672d0160912041419s2cbcb8ech49f69250b99386ae@mail.gmail.com>

Björn Gustavsson <bgustavsson@gmail.com> writes:

Show 10 quoted lines

> On Fri, Dec 4, 2009 at 3:36 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>
>> If the idea of a "fix" command is acceptable, then I would like to
>> implement a further convenience: if a group of commits to be folded
>> together includes *only* "fix" commits, then the first log message
>> should be used without even opening an editor. But I would like to
>> get a reaction to the "fix" command in general before doing so.
>
> I would really prefer that the editor is not entered at all if there
> are only "fix" commands in a group of commits to be folded.

I think all of these ideas were already discussed in the earlier thread from mid June this year, so I do not think there is no need for any more "me too like it" comments to show the support for this feature, unless it adds any new ideas of value. I think "fixup and nothing else shouldn't open editor" and "an option to pay attention to specially marked commit" are good ideas but they both appear in the old thread already.

IIRC, the end result of the bikeshedding for the name of the command was won by Dscho's "fixup":

  http://thread.gmane.org/gmane.comp.version-control.git/127923/focus=121820