git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing

From
Jayesh Daga via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 22, 2026, 13:50 UTC
Message-ID
<pull.2248.git.git.1774187447563.gitgitgadget@gmail.com>
From: jayesh0104 <jayeshdaga99@gmail.com>

test_path_is_missing expects exactly one argument: the path to check for absence. Passing '-f' is incorrect and results in "bug in the test script: 1 param" during test execution.

The '-f' flag appears to have been carried over from the equivalent 'test -f' usage, but test_path_is_missing does not accept such flags.

Remove the extraneous '-f' to use the helper correctly and restore proper test behavior.

Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
    t/pack-refs-tests: fix helper usage
    
    
    High-level (Intent & Context)
    =============================
    
    The test script t/pack-refs-tests.sh has two issues that prevent it from
    running correctly.
    
    It uses: ! test -f .git/refs/heads/f
    
    This is inconsistent with the Git test framework, where helper functions
    such as test_path_is_missing should be used instead of raw test checks.
    
    
    Low-level (Implementation & Justification)
    ==========================================
    
    Without sourcing test-lib.sh, the test framework is not initialized,
    leading to errors such as: test_expect_success: not found
    
    Replaced raw file check with the appropriate helper:
    
    - ! test -f .git/refs/heads/f
    + test_path_is_missing .git/refs/heads/f
    
    
    
    Summary
    =======
    
    Replace test -f with test_path_is_missing
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2248%2Fjayesh0104%2Ffix-pack-refs-test-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2248/jayesh0104/fix-pack-refs-test-v1
Pull-Request: https://github.com/git/git/pull/2248
 t/pack-refs-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
index 2fdaccb6c7..4a85d96c6b 100644
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
 test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
 	git branch f &&
 	git ${pack_refs} --all --prune &&
-	! test -f .git/refs/heads/f
+	test_path_is_missing .git/refs/heads/f
 '
 
 test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '

base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad
-- 
gitgitgadget
Next: K Jayatheerth
Message 1 of 14 in “t/pack-refs-tests: drop '-f' from test_path_is_missing”
  1. t/pack-refs-tests: drop '-f' from test_path_is_missingJayesh Daga via GitGitGadget, Mar 22, 2026
  2. K JayatheerthMar 22, 2026
  3. Tian YuchenMar 22, 2026
  4. jayesh0104Mar 24, 2026
  5. t/pack-refs-tests: drop '-f' from test_path_is_missingjayesh0104, Mar 24, 2026
  6. Eric SunshineMar 24, 2026
  7. t/pack-refs-tests: use test_path_is_missingjayesh0104, Mar 24, 2026
  8. Junio C HamanoMar 24, 2026
  9. t/pack-refs-tests: use test_path_is_missingJayesh Daga, Mar 24, 2026
  10. Tian YuchenMar 25, 2026
  11. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Mar 25, 2026
  12. Junio C HamanoMar 25, 2026
  13. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Apr 2, 2026
  14. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga via GitGitGadget, Apr 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.