[PATCH v6] tests: use test_path_is_missing instead of '! test -f'
- From
Jayesh Daga <jayeshdaga99@gmail.com>
- Date
- Apr 2, 2026, 16:39 UTC
- Message-ID
- <20260402163904.14046-1-jayeshdaga99@gmail.com>
- In-Reply-To
- <xmqqecl7u2ue.fsf@gitster.g>
From: jayesh0104 <jayeshdaga99@gmail.com>
Using plain "test" commands in a sequence of checks chained with `&&` makes it difficult to determine which step failed, as "test" silently succeeds or fails.
In this case, we expect that `.git/refs/heads/f` no longer exists. Replacing `! test -f` with `test_path_is_missing` preserves the expected behavior when the file is absent, but provides a clearer diagnostic when it unexpectedly exists, making test failures easier to debug.
Signed-off-by: Jayesh Daga [jayeshdaga99@gmail.com] --- t/pack-refs-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh index 2fdaccb6c7..4a85d96c6b 100644 --- a/t/pack-refs-tests.sh +++ b/t/pack-refs-tests.sh @@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune test_expect_success 'see if git ${pack_refs} --prune remove ref files' ' git branch f && git ${pack_refs} --all --prune && - ! test -f .git/refs/heads/f + test_path_is_missing .git/refs/heads/f ' test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
-- 2.43.0