git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 18:03 UTC

[PATCH v5] tests: use test_path_is_missing instead of '! test -f'

From
Jayesh Daga <jayeshdaga99@gmail.com>
Date
Mar 25, 2026, 17:44 UTC
Message-ID
<20260325174431.73101-4-jayeshdaga99@gmail.com>
In-Reply-To
<8dcc9e74-80a9-4963-aa9b-56f28e5edf45@gmail.com>
Replace a raw '! test -f' check with test_path_is_missing.

The test_path_is_missing helper integrates with Git’s test framework and produces clearer failure output. In contrast, a plain shell '! test -f' check only reports a generic failure status, which makes it harder to understand whether the file unexpectedly exists or if another issue caused the test to fail.

It also avoids relying on negated shell conditions, making the test easier to read and understand.

Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
v5:
- Clarify rationale for using test helper
- Explain diagnostic improvement and negation issues
- Address review comments on vague wording
v4:
- Correct commit message to match actual change
- Improve rationale (diagnostics, consistency)
- Move version notes below '---'
- Fix author name to match sign-off
v3:
- Fix commit message wording
---
 t/pack-refs-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
index 2fdaccb6c7..4a85d96c6b 100644
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
 test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
 	git branch f &&
 	git ${pack_refs} --all --prune &&
-	! test -f .git/refs/heads/f
+	test_path_is_missing .git/refs/heads/f
 '
 
 test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
-- 
2.43.0
Previous: Tian YuchenNext: Junio C Hamano
Message 11 of 14 in “t/pack-refs-tests: drop '-f' from test_path_is_missing”
  1. t/pack-refs-tests: drop '-f' from test_path_is_missingJayesh Daga via GitGitGadget, Mar 22, 2026
  2. K JayatheerthMar 22, 2026
  3. Tian YuchenMar 22, 2026
  4. jayesh0104Mar 24, 2026
  5. t/pack-refs-tests: drop '-f' from test_path_is_missingjayesh0104, Mar 24, 2026
  6. Eric SunshineMar 24, 2026
  7. t/pack-refs-tests: use test_path_is_missingjayesh0104, Mar 24, 2026
  8. Junio C HamanoMar 24, 2026
  9. t/pack-refs-tests: use test_path_is_missingJayesh Daga, Mar 24, 2026
  10. Tian YuchenMar 25, 2026
  11. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Mar 25, 2026
  12. Junio C HamanoMar 25, 2026
  13. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga via GitGitGadget, Apr 2, 2026
  14. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Apr 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.