git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3] t/pack-refs-tests: use test_path_is_missing

From
jayesh0104 <jayeshdaga99@gmail.com>
Date
Mar 24, 2026, 04:46 UTC
Message-ID
<20260324044619.43944-1-jayeshdaga99@gmail.com>
In-Reply-To
<a26599ba-01b0-4587-ba0c-bd28a822c615@gmail.com>
Replace the raw file existence check:
    ! test -f .git/refs/heads/f
with the Git test helper:
    test_path_is_missing .git/refs/heads/f

This aligns the test with Git’s testing conventions and avoids direct use of shell test constructs.

v3:
- Fix commit message to accurately describe the change
Signed-off-by: jayesh0104 <jayeshdaga99@gmail.com>
---
 t/pack-refs-tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/pack-refs-tests.sh b/t/pack-refs-tests.sh
index 2fdaccb6c7..4a85d96c6b 100644
--- a/t/pack-refs-tests.sh
+++ b/t/pack-refs-tests.sh
@@ -61,7 +61,7 @@ test_expect_success 'see if a branch still exists after git ${pack_refs} --prune
 test_expect_success 'see if git ${pack_refs} --prune remove ref files' '
 	git branch f &&
 	git ${pack_refs} --all --prune &&
-	! test -f .git/refs/heads/f
+	test_path_is_missing .git/refs/heads/f
 '
 
 test_expect_success 'see if git ${pack_refs} --prune removes empty dirs' '
-- 
2.43.0
Previous: Eric SunshineNext: Junio C Hamano
Message 7 of 14 in “t/pack-refs-tests: drop '-f' from test_path_is_missing”
  1. t/pack-refs-tests: drop '-f' from test_path_is_missingJayesh Daga via GitGitGadget, Mar 22, 2026
  2. K JayatheerthMar 22, 2026
  3. Tian YuchenMar 22, 2026
  4. jayesh0104Mar 24, 2026
  5. t/pack-refs-tests: drop '-f' from test_path_is_missingjayesh0104, Mar 24, 2026
  6. Eric SunshineMar 24, 2026
  7. t/pack-refs-tests: use test_path_is_missingjayesh0104, Mar 24, 2026
  8. Junio C HamanoMar 24, 2026
  9. t/pack-refs-tests: use test_path_is_missingJayesh Daga, Mar 24, 2026
  10. Tian YuchenMar 25, 2026
  11. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Mar 25, 2026
  12. Junio C HamanoMar 25, 2026
  13. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga, Apr 2, 2026
  14. tests: use test_path_is_missing instead of '! test -f'Jayesh Daga via GitGitGadget, Apr 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.