Re: [PATCH] t/pack-refs-tests: drop '-f' from test_path_is_missing

From: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Date: Mar 22, 2026, 14:27 UTC
Message-ID: <CA+rGoLdZWz2vfkvv3jm5_yX73gitWPGfySqbkw4e8Upy_2Hv9g@mail.gmail.com>
In-Reply-To: <pull.2248.git.git.1774187447563.gitgitgadget@gmail.com>

On Sun, Mar 22, 2026 at 7:20 PM Jayesh Daga via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 15 quoted lines

>
> From: jayesh0104 <jayeshdaga99@gmail.com>
>
> test_path_is_missing expects exactly one argument: the path to
> check for absence. Passing '-f' is incorrect and results in
> "bug in the test script: 1 param" during test execution.
>
> The '-f' flag appears to have been carried over from the
> equivalent 'test -f' usage, but test_path_is_missing does not
> accept such flags.
>
> Remove the extraneous '-f' to use the helper correctly and
> restore proper test behavior.
>
> Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>

While the code itself is now fine in my eyes, you aren't actually removing a -f flag here as described in the commit message. In the diff, you are entirely replacing the raw command with the test_path_is_missing helper.

I did a similar microproject earlier this year, and you can look at my commit message here for a reference [1]

Also, if this is for your GSoC microproject, you should probably add a tag in your patch subject line (something like [GSoC] ).

One other thing I should mention: you should make sure to CC the mentors for the specific project you are applying to so they see your work! or if you think the change is directly based on someone's work you can CC them as well.

I am happy to review the code and help out, but just letting you know I am a fellow GSoC applicant and not an official mentor.

Regards,
- Jayatheerth

1 - https://lore.kernel.org/git/CALE2CrS0Q2NS1DbFv4pyRQsuypu=KH6Kurs=m4yWrFbR9QosoA@mail.gmail.com/T/#mbbd865b0c73a93096df476621d485f15674f475b