Re: [PATCH 2/4] *: use singular they in comments
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 10, 2021, 08:20 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2106101018510.57@tvgsbejvaqbjf.bet>
- In-Reply-To
- <87bl8h4n01.fsf@evledraar.gmail.com>
Hi,
On Mon, 7 Jun 2021, Ævar Arnfjörð Bjarmason wrote:
Show 19 quoted lines
> On Mon, Jun 07 2021, Derrick Stolee via GitGitGadget wrote: > > > From: Derrick Stolee <dstolee@microsoft.com> > > > > Several comments in our code refer to an anonymous user with "he/him" or > > "she/her" pronouns, and the choice between the two is arbitrary. > > > > Replace these uses with "they/them" which universally includes all > > potential readers. > > > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > > --- > > commit.c | 2 +- > > config.h | 2 +- > > contrib/hooks/multimail/git_multimail.py | 4 ++-- > > We should not change upstream projects we pull in like that, see > README.Git in that directory + > https://github.com/git-multimail/git-multimail.
It is probably a good idea to make that upstream project not only the authoritative source, but the only source. In other words, I think we should replace the files in `contrib/hooks/multimail/` by a `README` that points to the indicated URL.
Ciao, Dscho