Re: [PATCH 0/2] Fix git stash with skip-worktree entries

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 29, 2019, 08:15 UTC
Message-ID: <nycvar.QRO.7.76.6.1910290913110.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqzhhk70fd.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 29 Oct 2019, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> Yeah, I do not recall seeing any of the patches in the topic (nor
> >> the cover letter).  It is not clear to me what "lose" above means,
> >> which is an indication that I didn't read the topic a month ago X-<.
> >
> > Sorry, in this context, "to lose a file" means that a `git stash` would
> > record such a file as deleted. A subsequent `git stash apply` _would_
> > then delete it.
>
> That would be a good thing to explain in the log message.

I thought that this paragraph in the commit message was describing this issue appropriately?

    When calling `git stash` while changes were staged for files that are
    marked with the `skip-worktree` bit (e.g. files that are excluded in a
    sparse checkout), the files are recorded as _deleted_ instead.

Do you agree that this is good enough?

Ciao, Dscho