Re: What's cooking in git.git (topics)
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Nov 4, 2007, 09:43 UTC
- Message-ID
- <fgk476$lha$1@ger.gmane.org>
- In-Reply-To
- <7vr6j6ve90.fsf@gitster.siamese.dyndns.org>
[Cc: Junio C Hamano <gitster@pobox.com>, git @vger.kernel.org]
Junio C Hamano wrote:
> * jn/gitweb (Sat Nov 3 00:41:20 2007 +0100) 9 commits
Now that I have sned those patches ;-) I have a few doubts about them
> + gitweb: Use config file for repository description and URLs > + gitweb: Read repo config using 'git config -z -l'
I'd like some comments on that series, preferably by someone better with Perl than me, but I think this is a good change performance wise.
> + gitweb: Add tests for overriding gitweb config with repo config
More tests is always good.
Show 5 quoted lines
> + gitweb: Use href(-replay=>1, action=>...) to generate alternate > views > + gitweb: Use href(-replay=>1, page=>...) to generate pagination > links > + gitweb: Easier adding/changing parameters to current URL
Now I'm not so sure about this, because it changes semantics of "next page" and alternate view links: after this series they count from current version, not from the displayed version.
But perhaps those doubts are unnecessary...
> + gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb > test
This removes unnecessary code, which can cause mysterious errors.
> + gitweb: Add 'status_str' to parse_difftree_raw_line output > + gitweb: Always set 'from_file' and 'to_file' in > parse_difftree_raw_line
This simplifies gitweb code, and I think there aren't any issues with those patches.
> Will push these out to 'master' over the weekend.
Thanks.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git