Re: What's cooking in git.git (topics)
On Thu, Nov 01, 2007 at 06:33:13PM +0000, Linus Torvalds wrote:
Show 15 quoted lines
>
>
> On Wed, 31 Oct 2007, Junio C Hamano wrote:
> >
> > * ph/parseopt (Tue Oct 30 14:15:21 2007 -0500) 23 commits
> > + ...
> >
> > It appears 1.5.4 will be, to a certain extent, a "Let's clean up
> > the internal implementation" release. This series should become
> > part of it. Hopefully will merge to 'master' soon, but I
> > haven't looked this series very closely yet.
>
> I certainly think this should go in, but it does make one deficiency
> painfully clear: the remaining shell scripts end up having all the old
> flags behaviour.
Those are not the only commands with issues: not all builtins are
migrated on the new option parser, and those with recursive options (I
mean the ones that use diff options e.g.) are not migrated yet either,
because the option parser does not supports a mechanism to deal with
them.
The issue is not to let parse_option recurse into anoter option
structure, it's that if you do so, you want to express the address of
the "options" to patch in a relative and not absolute way, and I've not
decided myself mind about a way to do that yet.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
Pierre Habouzit <madcoder@debian.org>