Re: [PATCH] builtin-commit: fix "git add x y && git commit y" committing x, too

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2007, 09:18 UTC
Message-ID: <7v8x4vykqm.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vk5ohuunv.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> I noticed that the implementation left next-index crufts almost
> every time it was run, and started to clean it up.  Here is
> still a WIP and it does not optimize the read_tree(HEAD) part,
> but you should be able to replace that part with your one-way
> merge easily.  As I haven't done that ls-files --error-unmatch
> equivalent, this does not pass tests that involve partial
> commits with added or removed paths.

I was working on this tonight. Will send out a proposed fix based on this WIP shortly. The result seems to pass all the tests.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.