Re: [PATCH v3 4/7] revision.c: begin refactoring --topo-order logic

From: Johannes Sixt <j6t@kdbg.org>
Date: Oct 12, 2018, 16:15 UTC
Message-ID: <fa365691-e8ae-4aa8-5c76-b5c8c925c2f8@kdbg.org>
In-Reply-To: <xmqqwoqnbrmw.fsf@gitster-ct.c.googlers.com>

Am 12.10.18 um 08:33 schrieb Junio C Hamano:

Show 12 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> +struct topo_walk_info {};
>> +
>> +static void init_topo_walk(struct rev_info *revs)
>> +{
>> +	struct topo_walk_info *info;
>> +	revs->topo_walk_info = xmalloc(sizeof(struct topo_walk_info));
>> +	info = revs->topo_walk_info;
>> +	memset(info, 0, sizeof(struct topo_walk_info));
> 
> There is no member in the struct at this point.  Are we sure this is
> safe?  Just being curious.

sizeof cannot return 0. sizeof(struct topo_walk_info) will be 1 here.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.