Re: [PATCH v4 0/7] Use generation numbers for --topo-order
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 1, 2018, 13:49 UTC
- Message-ID
- <9ffd8ecd-5595-ad19-cfe1-a268e3fa1bd3@gmail.com>
- In-Reply-To
- <xmqqpnvptlta.fsf@gitster-ct.c.googlers.com>
On 11/1/2018 1:21 AM, Junio C Hamano wrote:
Show 11 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> This patch series performs a decently-sized refactoring of the revision-walk >> machinery. Well, "refactoring" is probably the wrong word, as I don't >> actually remove the old code. Instead, when we see certain options in the >> 'rev_info' struct, we redirect the commit-walk logic to a new set of methods >> that distribute the workload differently. By using generation numbers in the >> commit-graph, we can significantly improve 'git log --graph' commands (and >> the underlying 'git rev-list --topo-order'). > Review discussions seem to have petered out. Would we merge this to > 'next' and start cooking, perhaps for the remainder of this cycle?
Thanks, but I've just sent a v5 responding to Jakub's feedback on v4. [1]
I'd be happy to let it sit in next until you feel it has cooked long enough. I'm available to respond to feedback in the form of new topics.
Thanks, -Stolee
[1] https://public-inbox.org/git/20181101134623.84055-1-dstolee@microsoft.com/T/#u