Re: [PATCH v3 2/7] test-reach: add run_three_modes method
- From
Jeff King <peff@peff.net>
- Date
- Oct 11, 2018, 13:57 UTC
- Message-ID
- <20181011135659.GB27312@sigill.intra.peff.net>
- In-Reply-To
- <b2a1ade148bc5ef175338ba116bd33b6b5e8d386.1537551564.git.gitgitgadget@gmail.com>
On Fri, Sep 21, 2018 at 10:39:29AM -0700, Derrick Stolee via GitGitGadget wrote:
Show 15 quoted lines
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The 'test_three_modes' method assumes we are using the 'test-tool
> reach' command for our test. However, we may want to use the data
> shape of our commit graph and the three modes (no commit-graph,
> full commit-graph, partial commit-graph) for other git commands.
>
> Split test_three_modes to be a simple translation on a more general
> run_three_modes method that executes the given command and tests
> the actual output to the expected output.
>
> [...]
> +test_three_modes () {
> + run_three_modes test-tool reach "$@"
> +}Makes sense. Sometimes in the test suite we want to be able to pass a whole shell snippet to eval, but unless we specifically need that for this series, running "$@" directly is simpler.
-Peff