Re: [PATCH v3 4/7] revision.c: begin refactoring --topo-order logic
- From
Jeff King <peff@peff.net>
- Date
- Oct 11, 2018, 14:06 UTC
- Message-ID
- <20181011140610.GD27312@sigill.intra.peff.net>
- In-Reply-To
- <fd1a0ab7cdaa06fd99f86fec51b483238f588296.1537551564.git.gitgitgadget@gmail.com>
On Fri, Sep 21, 2018 at 10:39:32AM -0700, Derrick Stolee via GitGitGadget wrote:
Show 9 quoted lines
> [..] > When setting revs->limited only because revs->topo_order is true, > only do so if generation numbers are not available. There is no > reason to use the new logic as it will behave similarly when all > generation numbers are INFINITY or ZERO. > > In prepare_revision_walk(), if we have revs->topo_order but not > revs->limited, then we trigger the new logic. It breaks the logic > into three pieces, to fit with the existing framework:
Nicely explained. Your abstracted init/next/expand API seems sane, but of course the real test will be reading the later patches that make use of it. :)
The patch matches my understanding of your explanation.
-Peff