Re: [PATCH v4 3/7] test-reach: add rev-list tests
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Oct 21, 2018, 15:28 UTC
- Message-ID
- <4d0587d1-d204-2507-3ac4-20358ed70ad0@gmail.com>
- In-Reply-To
- <865zxvior3.fsf@gmail.com>
On 10/21/2018 6:21 AM, Jakub Narebski wrote:
Show 15 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> From: Derrick Stolee <dstolee@microsoft.com> >> >> The rev-list command is critical to Git's functionality. Ensure it >> works in the three commit-graph environments constructed in >> t6600-test-reach.sh. Here are a few important types of rev-list >> operations: >> >> * Basic: git rev-list --topo-order HEAD >> * Range: git rev-list --topo-order compare..HEAD >> * Ancestry: git rev-list --topo-order --ancestry-path compare..HEAD >> * Symmetric Difference: git rev-list --topo-order compare...HEAD > Could you remind us here which of those operations will be using > generation numbers after this patch series?
For this series, we are focused only on the --topo-order with a single start position. The versions that use a compare branch still use the old logic. In the future, I would like to use the new logic for these other modes.
Show 16 quoted lines
>> >> +test_expect_success 'rev-list: basic topo-order' ' >> + git rev-parse \ >> + commit-6-6 commit-5-6 commit-4-6 commit-3-6 commit-2-6 commit-1-6 \ >> + commit-6-5 commit-5-5 commit-4-5 commit-3-5 commit-2-5 commit-1-5 \ >> + commit-6-4 commit-5-4 commit-4-4 commit-3-4 commit-2-4 commit-1-4 \ >> + commit-6-3 commit-5-3 commit-4-3 commit-3-3 commit-2-3 commit-1-3 \ >> + commit-6-2 commit-5-2 commit-4-2 commit-3-2 commit-2-2 commit-1-2 \ >> + commit-6-1 commit-5-1 commit-4-1 commit-3-1 commit-2-1 commit-1-1 \ >> + >expect && >> + run_three_modes git rev-list --topo-order commit-6-6 >> +' > I wonder if this test could be make easier to write and less error > prone, e.g. creating it from ASCII-art graphics. > > But it is good enough.
I did lay out the branch names in a grid layout similar to the commit-graph layout. It's easier to see the purposeful layout in the comparison sections where some commits don't appear in the output.
Thanks,
-Stolee