[PATCH v2 25/25] submodule_uses_worktrees(): plug memory leak

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 28, 2017, 14:04 UTC
Message-ID: <f3a803b812e74c7ea4166fdc443a16129784d133.1493387231.git.johannes.schindelin@gmx.de>
In-Reply-To: <cover.1493387231.git.johannes.schindelin@gmx.de>

There is really no reason why we would need to hold onto the allocated string longer than necessary.

Reported by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 worktree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/worktree.c b/worktree.c
index bae787cf8d7..89a81b13de3 100644
--- a/worktree.c
+++ b/worktree.c
@@ -399,6 +399,7 @@ int submodule_uses_worktrees(const char *path)
 
 	/* The env would be set for the superproject. */
 	get_common_dir_noenv(&sb, submodule_gitdir);
+	free(submodule_gitdir);
 
 	/*
 	 * The check below is only known to be good for repository format
@@ -418,7 +419,6 @@ int submodule_uses_worktrees(const char *path)
 	/* See if there is any file inside the worktrees directory. */
 	dir = opendir(sb.buf);
 	strbuf_release(&sb);
-	free(submodule_gitdir);
 
 	if (!dir)
 		return 0;

-- 
2.12.2.windows.2.800.gede8f145e06