[PATCH 02/26] winansi: avoid use of uninitialized value

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 26, 2017, 20:19 UTC
Message-ID: <ead7050c37093820e3fd097dc31bc56204eee59a.1493237937.git.johannes.schindelin@gmx.de>
In-Reply-To: <cover.1493237937.git.johannes.schindelin@gmx.de>

When stdout is not connected to a Win32 console, we incorrectly used an uninitialized value for the "plain" character attributes.

Detected by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 compat/winansi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/compat/winansi.c b/compat/winansi.c
index 793420f9d0d..fd6910746c8 100644
--- a/compat/winansi.c
+++ b/compat/winansi.c
@@ -105,6 +105,8 @@ static int is_console(int fd)
 	if (!fd) {
 		if (!GetConsoleMode(hcon, &mode))
 			return 0;
+		sbi.wAttributes = FOREGROUND_BLUE | FOREGROUND_GREEN |
+			FOREGROUND_RED;
 	} else if (!GetConsoleScreenBufferInfo(hcon, &sbi))
 		return 0;

-- 
2.12.2.windows.2.800.gede8f145e06