Re: [PATCH 18/26] fast-export: avoid leaking memory in handle_tag()
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Apr 27, 2017, 16:39 UTC
- Message-ID
- <885f5dbc-b5d0-5113-d2ee-e9bac47c4271@kdbg.org>
- In-Reply-To
- <1eda2649781a15264e9995e705d19206185dbbb1.1493237937.git.johannes.schindelin@gmx.de>
Am 26.04.2017 um 22:21 schrieb Johannes Schindelin:
Show 20 quoted lines
> Reported by, you guessed it, Coverity. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > builtin/fast-export.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/builtin/fast-export.c b/builtin/fast-export.c > index e0220630d00..828d41c0c11 100644 > --- a/builtin/fast-export.c > +++ b/builtin/fast-export.c > @@ -765,6 +765,7 @@ static void handle_tag(const char *name, struct tag *tag) > (int)(tagger_end - tagger), tagger, > tagger == tagger_end ? "" : "\n", > (int)message_size, (int)message_size, message ? message : ""); > + free(buf); > } > > static struct commit *get_commit(struct rev_cmdline_entry *e, char *full_name) >
There is an early return in the function that is not covered by this patch. Look for "case DROP".
-- Hannes