[PATCH v3 01/25] mingw: avoid memory leak when splitting PATH
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 2, 2017, 16:00 UTC
- Message-ID
- <10fc0a4a37b4167f49c967ece08f531cb1e8d6b1.1493740497.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1493740497.git.johannes.schindelin@gmx.de>
In the (admittedly, concocted) case that PATH consists only of colons, we would leak the duplicated string.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- compat/mingw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c index 3fbfda5978b..fe0e3ccd248 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -961,8 +961,10 @@ static char **get_path_split(void) ++n; } } - if (!n) + if (!n) { + free(envpath); return NULL; + } ALLOC_ARRAY(path, n + 1); p = envpath;
-- 2.12.2.windows.2.800.gede8f145e06