Re: [PATCH 20/26] line-log: avoid memory leak

From: Johannes Sixt <j6t@kdbg.org>
Date: Apr 27, 2017, 17:14 UTC
Message-ID: <4ae94881-305f-380b-e786-c7f4ea5735e3@kdbg.org>
In-Reply-To: <0051da81b5cffe53122c036122402418c7f8d55f.1493237937.git.johannes.schindelin@gmx.de>

Am 26.04.2017 um 22:21 schrieb Johannes Schindelin:

Show 20 quoted lines

> Discovered by Coverity.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  line-log.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/line-log.c b/line-log.c
> index a23b910471b..19d46e9ea2c 100644
> --- a/line-log.c
> +++ b/line-log.c
> @@ -1125,6 +1125,7 @@ static int process_ranges_ordinary_commit(struct rev_info *rev, struct commit *c
>  	changed = process_all_files(&parent_range, rev, &queue, range);
>  	if (parent)
>  		add_line_range(rev, parent, parent_range);
> +	free(parent_range);
>  	return changed;
>  }
>
>

parent_range is of type struct line_log_data *, which needs more than a mere free(). I think it's free_line_log_data(parent_range).

-- Hannes